search

FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.69k stars 587 forks source link

don't show duplicated "Skip turn" text on hover [bounty: 3 XTR] #2562

Closed DreadKnight closed 8 months ago

DreadKnight commented 8 months ago

This is related to #2536 / #2558 Hovering on-off-on the active unit that doesn't have anything else to do sort of briefly displays "Skip turn" twice. Only the icon should be animated coming or going depending of the unit is being hovered or not.

EngineerPehr commented 8 months ago

I'm new to open source, and I would love to take a crack at this issue. I have been working with Javascript for about 3 years.

DreadKnight commented 8 months ago

@EngineerPehr Heya! Alright, assigning you to it. 2 weeks soft deadline :bear:

EngineerPehr commented 8 months ago

@DreadKnight I was able to fix this by changing the animation speed. However, based on feedback from some friends I had play the game with me, I think it might be worth changing the text of the "no_actions" tooltip to something like "Out of Actions" and "End Turn". Do you want me to do that before creating a pull request?

DreadKnight commented 8 months ago

@DreadKnight I was able to fix this by changing the animation speed. However, based on feedback from some friends I had play the game with me, I think it might be worth changing the text of the "no_actions" tooltip to something like "Out of Actions" and "End Turn". Do you want me to do that before creating a pull request?

@EngineerPehr In Ancient Beast, "End Turn" is "Skip Turn", due to us using hotkeys focused on QUERTY type of keyboard. Pressing "S" => skips the turn. Text is ok, as it's enforcing the consistency of the action. Feel free to make PR for the fix 👍🏻