[#2537] indicate selected ability when targeting

FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺

https://AncientBeast.com

GNU Affero General Public License v3.0

1.66k stars 569 forks source link

[#2537] indicate selected ability when targeting #2567

Open weiquu opened 6 months ago

weiquu commented 6 months ago

This fixes issue #2537

My wallet address is 0x848fBf0588B448f14a2a8BA84Ef12711677073Db

Outline of solution:

Added the svgs for unit abilities to Phaser assets so that they can be used for sprite textures
Add 'ability' to the hovered hex's overlay visual state, remove it on click (ability used) and hover off
If 'ability' is in the overlay classes and there is an ability selected, add the appropriate abilityIcon; else, set alpha to 0
Frame and background are set in the hex's constructor, with alpha toggled along with the the abilityIcon
abilityIcon brought to top of overlay group each time it's displayed so the icon can be seen more clearly

Example: Screenshot 2024-03-29 at 10 31 24 PM

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ancientbeast	✅ Ready (Inspect)	Visit Preview	Mar 29, 2024 2:33pm

DreadKnight commented 6 months ago

@weiquu Heya! Um, no resizing of icons please; use other ways for spacing out stuff, like adding extra divs and using code.

weiquu commented 6 months ago

Hey @DreadKnight, I meant scaling the sprites down, not actually changing the .svg files. Is that fine? I did something similar here as well

DreadKnight commented 6 months ago

Hey @DreadKnight, I meant scaling the sprites down, not actually changing the .svg files. Is that fine? I did something similar here as well

Doing it through code like that should be ok. I get that this is a draft, just wanted to make sure of this approach aspect.

weiquu commented 6 months ago

@DreadKnight ready for review!

DreadKnight commented 6 months ago

@weiquu Only did some testing with Firefox, 2 stacked Dark Priests for each player, mouse wheel working badly and no showcased ability icons at all. Will test soon with Brave as well. Also, I understand that icons need to be moved into the autoload folder, but UI should use them from there, it's important to avoid duplicated, but you've changed the icons I think.

DreadKnight commented 5 months ago

@weiquu You can test it here btw -> https://ancientbeast-9pgv468k0-freezingmoon.vercel.app There's also web based IDE like VSC.

DreadKnight commented 1 day ago

@weiquu Hey, any progress with this one? 🐻