search

FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.66k stars 569 forks source link

Escort Service ability problematic [bounty: 16 XTR] #2582

Closed DreadKnight closed 1 month ago

DreadKnight commented 4 months ago

Scavenger's Escort Service is problematic, most of the time seems to be unusable with medium or large units (upgraded). Ability shows up as usable but you can't target hexagons for new location. This is a follow-up for the partial fix here: #2563

nohaibogdan1 commented 1 month ago

@DreadKnight Can you assign it to me ?

DreadKnight commented 1 month ago

@nohaibogdan1 Alright. 2 weeks soft deadline 🐻

nohaibogdan1 commented 1 month ago

@DreadKnight What are the rules for the escort service ?

Lets take the situation where Scavenger has target in front

From what I observed the escort service is working in the a way that the minimum backward move is the number of hexes equal to the sum of the units sizes.

I am thinking the actual behaviour should be that minimum backwards move is one hex.

Depending on deciding this I have to either fix the require function or query function of the escort service ability.

DreadKnight commented 1 month ago

@nohaibogdan1 Hmm, if going for minimum movement of one hex, it might make previewing new location a tad more awkward and eventually animation, not sure. Anyway, feel free to make a PR like that and we could take it from there, testing things in practice and adjusting stuff if something feels off.

nohaibogdan1 commented 1 month ago

@DreadKnight You are right. Let's go with the easier choice for the moment which is to fix the availability of the escort service (the button). Changing the way the escort service works implies a lot of work and I prefer to use my time in getting higher priority work done.

DreadKnight commented 1 month ago

@DreadKnight You are right. Let's go with the easier choice for the moment which is to fix the availability of the escort service (the button). Changing the way the escort service works implies a lot of work and I prefer to use my time in getting higher priority work done.

Will probably open new issues soon and have the ability more fine grained eventually, like you said, while also tackling the X-Ray feature in another issue regarding situations like these in order to not cause confusion. Anyway, one step at a time.

DreadKnight commented 1 month ago

@nohaibogdan1 I've opened issues #2616 and #2617, up for the taking, with XatteR bounties, as usual 🪙