search

FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.69k stars 587 forks source link

Skip turn icon added even when not hovered #2596

Closed Joywin2412 closed 3 months ago

Joywin2412 commented 3 months ago

This fixes issue #2583

My wallet address is 0xb15A6219c5ECa1a2dcA2D27b08CBfeee98EF1B81

image

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Aug 9, 2024 4:02pm
DreadKnight commented 3 months ago

@Joywin2412 Icon missing for me, on Linux using Firefox if it even matters... Screenshot_20240808_222007

Joywin2412 commented 3 months ago

That's very weird. It's only happening in firefox. Other browsers like Opera , Brave and Chrome are showing the image.

DreadKnight commented 3 months ago

That's very weird. It's only happening in firefox. Other browsers like Opera , Brave and Chrome are showing the image.

Good to know, will update original issue with that. I didn't get the chance to test with the other browsers, but makes sense.

Joywin2412 commented 3 months ago

The thing is .svg is having the problem. Now that is fixed I don't think other browsers must have this issue.

DreadKnight commented 3 months ago

@Joywin2412 I see, well done. Works fine now.

Please clean up your PR, a lot of files touched for no real reason, there's even your nickname in a comment there xD

Joywin2412 commented 3 months ago

Ah! Sorry kept my nickname for faster global search. I think prettier is messing a lot of files I'll do that without vscode.

DreadKnight commented 3 months ago

Ah! Sorry kept my nickname for faster global search. I think prettier is messing a lot of files I'll do that without vscode.

I use VSCode myself, you can hand pick the files when committing or revert stuff to original. Anyway, can't quite figure out from all that where asset changed from svg to png when getting loaded... hopefully some order will make all that obvious.

Joywin2412 commented 3 months ago

Ah! Sorry kept my nickname for faster global search. I think prettier is messing a lot of files I'll do that without vscode.

I use VSCode myself, you can hand pick the files when committing or revert stuff to original. Anyway, can't quite figure out from all that where asset changed from svg to png when getting loaded... hopefully some order will make all that obvious.

Now the changes are quite less.

DreadKnight commented 3 months ago

@Joywin2412 Merged and set bounty 🥳 -> https://www.mintme.com/explorer/tx/0x3cf73a61f8eef41f17d9abab6dd2648a895444e3b1f96b796f4d5133811abd2c 🪙