search

FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.65k stars 567 forks source link

branding missing when in iframe [bounty: 4 XTR] #2615

Open DreadKnight opened 3 weeks ago

DreadKnight commented 3 weeks ago

While pressing shift or hovering the round marker from the unit queue, the project logo (Ancient Beast text) doesn't display when the game is embedded via an iframe.

https://ancientbeast.com (embed via iframe) versus https://beta.ancientbeast.com (no embed).

nohaibogdan1 commented 3 weeks ago

@DreadKnight I will pick this one

DreadKnight commented 3 weeks ago

@nohaibogdan1 Alrighty, go for it! 🐻

nohaibogdan1 commented 2 weeks ago

@DreadKnight I cannot reproduce it, sent you a screenrecord on discord

DreadKnight commented 2 weeks ago

@DreadKnight I cannot reproduce it, sent you a screenrecord on discord

@nohaibogdan1 Yeah, apparently by editing that attribute you actually end up bypassing the bug. Perhaps you can reproduce by having a local html webpage and just have a similar iframe in it with some auto deployed game server for the branch tested, you can find a "View deployment" button a bit after pushing a PR here on Github which leads you to the proper link to use, but note that the subdomain changes with each new push.

nohaibogdan1 commented 2 weeks ago

@DreadKnight Still cannot reproduce it . I tried with this: 

<!DOCTYPE html>
<html>
    <body>
        <iframe 
          id="game" 
          name="game" 
          src="https://ancientbeast-git-fork-nohaibogdan1-fix-logo-d73687-freezingmoon.vercel.app/" 
          style="border: 4px ridge; border-color: grey; width: 934px; height: 525px;" 
          seamless="" 
          sandbox="allow-same-origin allow-forms allow-scripts allow-popups" 
          webkitallowfullscreen="" mozallowfullscreen="" allowfullscreen=""></iframe>
    </body>
</html>

How do you reproduce it ?

DreadKnight commented 2 weeks ago

@DreadKnight Still cannot reproduce it . I tried with this:

<!DOCTYPE html>
<html>
    <body>
        <iframe 
          id="game" 
          name="game" 
          src="https://ancientbeast-git-fork-nohaibogdan1-fix-logo-d73687-freezingmoon.vercel.app/" 
          style="border: 4px ridge; border-color: grey; width: 934px; height: 525px;" 
          seamless="" 
          sandbox="allow-same-origin allow-forms allow-scripts allow-popups" 
          webkitallowfullscreen="" mozallowfullscreen="" allowfullscreen=""></iframe>
    </body>
</html>

How do you reproduce it ?

https://github.com/FreezingMoon/AncientBeast-Website/blob/master/index.php#L33