Include native gen with plugin

Frege / frege-gradle-plugin

Gradle plugin for compiling Frege projects

BSD 3-Clause "New" or "Revised" License

25 stars 10 forks source link

Include native gen with plugin #19

Open mperry opened 9 years ago

mperry commented 9 years ago

Currently needs explicit native gen library in client project

Dierk commented 9 years ago

I'd say that an explicit dependency is not so bad

keeps native-gen optional with smaller download size if not needed
avoid version conflict in the transitive dependencies (Same for repl) This has to be weighed against convenience of course. I'm not sure what is best.

mperry commented 9 years ago

I think to help people get started it would be better to include everything by default. They can then override or exclude what they wish.

The problem is the tasks are defined in the plugin, but running the tasks will fail without the extra explicit dependencies. Not a pleasant suprise!

Version conflict is something that has to be watched of course, but as a user I want the primary library authors to sort that out. I don't want to have to do this with every library I consume.

Dierk commented 9 years ago

Agreed.

We should explain in the docs how to opt out.

Cheers Dierk

sent from:mobile

Am 17.09.2015 um 07:16 schrieb Mark Perry notifications@github.com:

I think to help people get started it would be better to include everything by default. They can then override or exclude what they wish.

The problem is the tasks are defined in the plugin, but running the tasks will fail without the extra explicit dependencies. Not a pleasant suprise!

Version conflict is something that has to be watched of course, but as a user I want the primary library authors to sort that out. I don't want to have to do this with every library I consume.

— Reply to this email directly or view it on GitHub.

mperry commented 9 years ago

This is my argument for including the frege artifact with the plugin too, but I remember a few people wanted that explicit. Not sure what other language plugins do by default, I have always made explicit reference to versions for Groovy and Scala in the dependencies, so I am guessing the primary language artifact is not included with the plugin.

Dierk commented 9 years ago

For the compiler/runtime it is often so that one wants to change/upgrade to a version different than the "bundled" one. Change should be simple and obvious.

Dierk

sent from:mobile

Am 17.09.2015 um 07:34 schrieb Mark Perry notifications@github.com:

This is my argument for including the frege artifact with the plugin too, but I remember a few people wanted that explicit. Not sure what other language plugins do by default, I have always made explicit reference to versions for Groovy and Scala in the dependencies, so I am guessing the primary language artifact is not included with the plugin.

— Reply to this email directly or view it on GitHub.