search

Frege / frege

Frege is a Haskell for the JVM. It brings purely functional programing to the Java platform.
https://github.com/Frege/frege/wiki/_pages
Other
3.64k stars 145 forks source link

catched -> caught, or even "show"? #84

Closed Dierk closed 9 years ago

Dierk commented 10 years ago

For "show"ing a Throwable, we use the "catched" function as defined in https://github.com/Frege/frege/blob/master/frege/prelude/PreludeBase.fr#L696-696

But "catched" isn't proper English, it should be named "caught". But rather than renaming it this way, how about renaming it to "show", which is otherwise used as the Frege equivalent to Java's toString.

Warning: this would be a breaking change! All users have to update.

Ingo60 commented 10 years ago

We must use caught then, as we must not (or, at least should not) overload class operation names. Unless this would be the one and only thinkable way to implement "show".

I really didn't know that catch is an irregular verb. Though, otoh I knew the word "caught", but to me it smells like fish. Am 11.11.2014 16:41 schrieb "Dierk König" notifications@github.com:

For "show"ing a Throwable, we use the "catched" function as defined in https://github.com/Frege/frege/blob/master/frege/prelude/PreludeBase.fr#L696-696

But "catched" isn't proper English, it should be named "caught". But rather than renaming it this way, how about renaming it to "show", which is otherwise used as the Frege equivalent to Java's toString.

Warning: this would be a breaking change! All users have to update.

— Reply to this email directly or view it on GitHub https://github.com/Frege/frege/issues/84.

Dierk commented 10 years ago

yes, it is like catching fish :-) However, "catched" falls through all spellcheckers that I have.

On the other account: can't we make Throwable an instance of the Show class?

Ingo60 commented 10 years ago

Can't check it right now from phone, but I thought it was already and show uses "catched" Am 11.11.2014 17:38 schrieb "Dierk König" notifications@github.com:

yes, it is like catching fish :-) However, "catched" falls through all spellcheckers that I have.

On the other account: can't we make Throwable an instance of the Show class?

— Reply to this email directly or view it on GitHub https://github.com/Frege/frege/issues/84#issuecomment-62574824.

Ingo60 commented 9 years ago

Fixed with commit 47addfe79e6581fa54597a706385e964cfef2c73

Attention, this invalidates all programs that use "catched". Check your sources!