search

Freifunk-Nord / gluon-ssid-changer

Other
1 stars 10 forks source link

Initialization fixes for v2018.1.x #20

Closed ecsv closed 6 years ago

ecsv commented 6 years ago

It was noticed that the package was not working at all on a fresh 2018.1.x installation. Here my report from IRC:

rubo77|m: the gluon-ssid-changer which you've tried to promote doesn't really work. it doesn't write the config data to /etc/config/ssid-changer for the current gluon-master version there are a couple of problems:

  1. you are trying to access the site data in your /lib/gluon/upgrade/500-ssid-changer like this: site.ssid_changer.prefix but this will not return strings. you need to do it like (!parentheses at the end) this: site.ssid_changer.prefix()
  2. you check in the upgrade script whether ssid-changer.settings.enabled and abort when it exists. but you've added a /etc/config/ssid-changer with exactly this data (and thus it aborts the initialization of the config data)
  3. you create you uci config section in the upgrade script as ssid-changer.settings=main but all other places do it as ssid-changer.settings=settings