search

FreifunkBremen / yanic

Yet another node info collector - for respondd to be used with meshviewer to Grafana (with influxdb or graphite)
https://freifunkbremen.github.io/yanic/
GNU Affero General Public License v3.0
20 stars 40 forks source link

Refactored filters not working properly #124

Closed belzebub40k closed 6 years ago

belzebub40k commented 6 years ago

I updated our installation to the latest master with the refactored filters but I have some problems with them.

  1. no_owner was renamed to noowner. The documentation still says it should be no_owner.
panic: filter configuration errors: [unknown filter: no_owner]
  1. blacklist and sites complain about invalid configuration but they are defines as shown in the documentation.
[nodes.output.meshviewer-ffrgb.filter]
blacklist = ["98ded0c5e0c0","ec086b6135da"]
sites = ["ffwi"]
panic: filter configuration errors: [unable to initialize filter blacklist: invalid configuration, array of strings expected]
panic: filter configuration errors: [unable to initialize filter sites: invalid configuration, array of strings expected]
genofire commented 6 years ago

Oo sry. i think i fix everything, and rename noowner back like before to no_owner

would you try: the bugfix-filter branch - #126

CI: https://circleci.com/gh/FreifunkBremen/yanic/809#artifacts/containers/0 - Build: https://809-52072179-gh.circle-artifacts.com/0/yanic/yanic

belzebub40k commented 6 years ago

Thanks, I'll give it a try.

belzebub40k commented 6 years ago

All 3 filters are now working as expected.

genofire commented 6 years ago

thx, merged now