search

FreifunkBremen / yanic

Yet another node info collector - for respondd to be used with meshviewer to Grafana (with influxdb or graphite)
https://freifunkbremen.github.io/yanic/
GNU Affero General Public License v3.0
20 stars 40 forks source link

yanic query: allow setting non default destination port #209

Open herbetom opened 2 years ago

herbetom commented 2 years ago

Currently it seems as if yanic query doesn't allow to set a destination port and instead alwas 1001 is beeing used.

For testing purposes it would be great if a option would be available to query devices on another port.

I only see a --port flag which can be used to change the source port.

maurerle commented 1 year ago

In yanic query, we land here: https://github.com/FreifunkBremen/yanic/blob/35e925355be7fd906d4a0b5861fae03c32372535/respond/collector.go#L225-L228

so we need to allow setting a port param to this function and the queryCmd for this to work

genofire commented 1 year ago

thats correct, we need therefore a bypass of parameter ...

current i am to lazy for developing it, sry. every component on freifunk use this port, so i will focus on more importent things ...

but i will review and merge it, if some else develop it. i believe it is an good first issue.