search

FremyCompany / css-grid-polyfill

A working implementation of css grids for current browsers.
MIT License
1.11k stars 82 forks source link

REQUEST: column-span #43

Open TejasQ opened 7 years ago

TejasQ commented 7 years ago

Please support grid-column: span 8;.

FremyCompany commented 7 years ago

I haven't looked at the code for a long time but I do have the vague feeling that should actually work. I guess it is a bug if it doesn't but maybe I am missing something. Could you write a test case? Also try variants to see what is supported vs what is not?

raphaelgoetter commented 7 years ago

It seems that this syntax works : grid-column: auto / span 8;.

FremyCompany commented 7 years ago

Thanks for investigating!

If someone want to take this issue, here is the code that parses that value: https://github.com/FremyCompany/css-grid-polyfill/blob/master/src/css-grid/lib/grid-layout.js#L233

This should be an easy fix if the polyfill doesn't match the spec here.

zabojad commented 7 years ago

grid-row: auto / span 8; doesn't seem to work...

raphaelgoetter commented 7 years ago

grid-row: auto / span 8; doesn't seem to work...

Only applies on explicit rows.