search

FremyCompany / css-grid-polyfill

A working implementation of css grids for current browsers.
MIT License
1.11k stars 82 forks source link

What's required to update to the latest spec? #50

Open RamIdeas opened 7 years ago

RamIdeas commented 7 years ago

Do you know what exactly would be involved in updating this polyfill to implement the latest specification?

Like, could you enumerate/bullet the steps required and possibly point to files/functions related to each?

I understand you may be too busy to update this polyfill yourself but this may enable someone to contribute without the daunting task of familiarising themselves with the codebase intricately before they begin.

FremyCompany commented 7 years ago

Sounds reasonable. I would start with the the already-opened issues, they should cover most of the work:

https://github.com/FremyCompany/css-grid-polyfill/issues/26 (gap properties) (#51) https://github.com/FremyCompany/css-grid-polyfill/issues/43 (column-span) https://github.com/FremyCompany/css-grid-polyfill/issues/16 (alignment) https://github.com/FremyCompany/css-grid-polyfill/issues/15 (calc) https://github.com/FremyCompany/css-grid-polyfill/issues/14 (auto-fill)

Then, the next step would be to try and run the layout tests of the grid spec, to find bugs and eliminate them. The javascript ones cannot pass (by design) but the layout ones should.

elken commented 7 years ago

I would also be interested in contributing, how does #51 fit in here and what's the status on merging it?

FremyCompany commented 7 years ago

Hum, I had not seen there had been updates to the PR, @RamIdeas didn't comment or close change requests to reset the status of the review. I think it's pretty far along, though looking at the demo he added, there is still a bit of work around percentages like I mentioned in https://github.com/FremyCompany/css-grid-polyfill/pull/51#discussion_r137344924 but I think I might be able to do this myself sometime this week.

If you're interested in contributing, I think an awesome issue to tackle would be https://github.com/FremyCompany/css-grid-polyfill/issues/16 (alignment)

I just added details on how to get started for that. Let me know if you have any question.

katerlouis commented 5 years ago

What's the status on supporting the latest spec?

FremyCompany commented 5 years ago

The list above (https://github.com/FremyCompany/css-grid-polyfill/issues/50#issuecomment-326388627) is accurate, except for grid-gap that has been implemented by a contributor. I edited the above list to reflect that so now it is fully accurate again.