Checking DEPENDS/IGNORE based on OSVERSION

FreshPorts / freshports

The website part of FreshPorts

http://www.freshports.org/

BSD 2-Clause "Simplified" License

69 stars 24 forks source link

Checking DEPENDS/IGNORE based on OSVERSION #381

Open dlangille opened 2 years ago

dlangille commented 2 years ago

Case in point: graphics/drm-kmod

$ make OSVERSION=1301000 -V RUN_DEPENDS 
/boot/modules/drm.ko:graphics/drm-fbsd13-kmod

$ make OSVERSION=1300000 -V RUN_DEPENDS 
gpu-firmware-kmod>=20220511:graphics/gpu-firmware-kmod

The RUN_DEPENDS varies depending upon which release you are running.

This would require:

The database does not have OSVERSION involved in DEPENDS - that table would need modification
What OSVERSION values get uses for this?
Where are they obtained from?
When new OSVERSION values come in, when do you start using them?
What do you do with old entries in the database?
If all the DEPENDS are the same for each OSVERSION, do you store a single set of values?

This could be applied to all DEPENDS: BUILD, LIB, RUN, etc.

It also applies to IGNORE, BROKEN.

This is not just adding another column to a table.

EDIT: This is not a priority for completion. There is a high work/risk/reward ratio.

dlangille commented 2 years ago

Zirias said: another "solution" could be to add a disclaimer in your templates somewhere: "Freshports shows ports as seen on a 12.3-RELEASE system on amd64"

dlangille commented 2 years ago

This affects:

about 137 ports which contain OSVERSION
1045 ports referencing BROKEN
464 ports referencing IGNORE

as found via grep -rl IGNORE * (for example).

This count doesn't try to figure out ports which get their values from other ports.

dlangille commented 2 years ago

This also doesn't try to consider variations dependent upon ARCH

dlangille commented 2 years ago

Let's say that's 1600 ports and that there are 38,000 ports.

This affects 4% of ports, roughly. Most definitely less because not ALL of the above indicate version specific instances.

grahamperrin commented 1 year ago

Case in point: graphics/drm-kmod

For posterity:

https://web.archive.org/web/20220807184534/https://www.freshports.org/graphics/drm-kmod/#dependencies around one month before this issue
https://web.archive.org/web/20221211080642/https://www.freshports.org/graphics/drm-kmod/#dependencies today.

In parallel, if I understand https://github.com/FreshPorts/freshports/issues/398#issuecomment-1275224264 correctly:

this week's update to graphics/drm-510-kmod does not trigger a change to https://www.freshports.org/graphics/drm-kmod/#dependencies
an update to graphics/drm-kmod will trigger a change

– https://github.com/freebsd/freebsd-ports/pull/140 and https://reviews.freebsd.org/D37672 are for a typo (and more) in the package description for graphics/drm-kmod.