Commit found by commit id: comprehension, and possible nits

[grahamperrin]

https://www.freshports.org/commit.php?category=databases&port=mysql55-client&files=yes&message_id=305f148f482daf30dcf728039d03d019f88344eb, for example:

• the uppermost line relates to games/0ad
• a long-ish list of stuff

Initially, I misunderstood this part of the page, below the long list:

– misunderstood because I had skipped through the page too fast and, of course, what's above that part of the page is not just "stuff" – each line is a commit. My bad, poor (lazy) comprehension.

---

Then, this part of the page:

Number of ports [& non-ports] in this commit: 29222

Hmm, did I truly skip through a list of nearly thirty thousand ports and non-ports?

No, and :-) I'm glad that FreshPorts did not present that many. From source of the page, I guess that there's a reasonable limit to the number of listings:

• 500

For edge cases such as this, the page might be improved to state the limit, and maybe explain how the subset (to be listed) was chosen.

---

Finally, after clicking show all files, I see a string of three threes not far from a string of three twos:

The triplets are eye-catching. The two counts might be true (I'm too lazy to check, at the moment) … but in the context of a page where something is limited, I get suspicious about things that catch my eye.

[grahamperrin]

Afterthought: presentation of the number of ports and non-ports

I might have been partly confused by the border that entirely surrounds the statement.

Whilst removing the top border might be conceptually better (not separating the statement from the area to which it relates), it might also cause the statement to be overlooked.

Maybe move the statement, to be above the list of ports and non-ports?

(Do I understand correctly?)

[grahamperrin]

Afterthought: the files section

Radio button representation might help to make what's bordered (above) more immediately recognisable as three distinct views. Something like this:

[ Hide files ] [[ Files for databases/mysql55-client alone ]] [ Show all files]

[dlangille]

Initially, I misunderstood this part of the page, below the long list:

– misunderstood because I had skipped through the page too fast and, of course, what's above that part of the page is not just "stuff" – each line is a commit. My bad, poor (lazy) comprehension.

The commit message should be collapsed (i.e. a summary) like it is on the data.php page (https://www.freshports.org/date.php?date=2021/4/6)

Also: perhaps the commit message should appear first, followed by the list of ports. This might be applied to all pages.

[dlangille]

Then, this part of the page:

Number of ports [& non-ports] in this commit: 29222

Hmm, did I truly skip through a list of nearly thirty thousand ports and non-ports?

No, and :-) I'm glad that FreshPorts did not present that many. From source of the page, I guess that there's a reasonable limit to the number of listings:

• 500

I think that's from here:

www/backend/commits.php: DEFINE('MAXROWS', 15000); www/commit.php: DEFINE('DEFAULT_PAGE_SIZE', 500);

For edge cases such as this, the page might be improved to state the limit, and maybe explain how the subset (to be listed) was chosen.

The page should list all the commits, however ugly that is. The collapsed state mentioned in a previous comment would apply.

Finally, after clicking show all files, I see a string of three threes not far from a string of three twos:

The triplets are eye-catching. The two counts might be true (I'm too lazy to check, at the moment) … but in the context of a page where something is limited, I get suspicious about things that catch my eye.

Any action required here? Just eye-catching?

[dlangille]

Afterthought: presentation of the number of ports and non-ports

I might have been partly confused by the border that entirely surrounds the statement.

Whilst removing the top border might be conceptually better (not separating the statement from the area to which it relates), it might also cause the statement to be overlooked.

Maybe move the statement, to be above the list of ports and non-ports?

(Do I understand correctly?)

Moving it to the top might be best.

[dlangille]

Afterthought: the files section

Radio button representation might help to make what's bordered (above) more immediately recognisable as three distinct views. Something like this:

[ Hide files ] [[ Files for databases/mysql55-client alone ]] [ Show all files]

That sounds better.

They are three separate pages are present. The URLs are different. Radio buttons don't seem right for launching a new page. The page could be changed though, to be just one.

[dlangille]

– misunderstood because I had skipped through the page too fast and, of course, what's above that part of the page is not just "stuff" – each line is a commit. My bad, poor (lazy) comprehension.

Each line is a port touched by this commit.

[dlangille]

There's more than one change suggestion here. This is the summary:

• don't show all 29,000 ports in such commits
• limit them to 500 (as now) and when that limit it hit, mention it
• Provide someway to see them all (collapsed list?)
• Hide files, Show all the files, just the files for this one port - can't be done via collapse I think - there are too many ports