Add github action to build extension list

FreshRSS / Extensions

A repository containing all the official FreshRSS extensions

GNU Affero General Public License v3.0

321 stars 52 forks source link

Add github action to build extension list #127

Closed aledeg closed 2 years ago

aledeg commented 2 years ago

@Frenzie What do you mean?

Frenzie commented 2 years ago

Just curious if the resulting JSON is the same.

On Mon, Jan 10, 2022 at 5:50 PM Alexis Degrugillier < @.***> wrote:

@Frenzie https://github.com/Frenzie What do you mean?

— Reply to this email directly, view it on GitHub https://github.com/FreshRSS/Extensions/pull/127#issuecomment-1009115601, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABRQBMYR2DBGQGGTETMIDLUVME67ANCNFSM5LSKF5GQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

aledeg commented 2 years ago

Yes, the resulting JSON is the same. I mean the same as if we generate it manually with the tool that has been merged yesterday. The tool change it slightly compared with what we have previously though, But overall, this won't change how the reader will use it. You can even check it by yourself on your instance. The list of extension is extracted from that file.

Alkarex commented 2 years ago

It is not really a part of this PR, but a few comments, not required (feel free to ignore):

Running generate.php twice leads to errors such as fatal: destination path '/tmp/extensions/10' already exists and is not an empty directory. Either remove the directories or prepare for git fetch ... && git reset ...
generate.php could be made +x executable
Maybe instead of /tmp/extensions/ the working directory could be ./data/extensions/ with the corresponding .gitignore to reduce the risks of collisions and abandoned temp files
The key in foreach ($gitRepositories as $key => $gitRepository) { could be a hash (e.g. sha1) of the repository URL for more stability than 0, 1, 2, 3...
Your JSON encode could use options such as JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE to be more human readable (avoid \/)

aledeg commented 2 years ago

@Alkarex I've addressed all your concerns. It should work as intended without making a difference in the output.