search

FreshRSS / Extensions

A repository containing all the official FreshRSS extensions
GNU Affero General Public License v3.0
321 stars 52 forks source link

Fix & improve Reading time extension #156

Closed sal0max closed 1 year ago

sal0max commented 1 year ago

As reported by @svemoe in #148, the Reading time extension doesn't work any more, beginning with 1.20. The fix would be relatively easy, by just changing the querySelector.

However, I'd suggest further improvement of the plugin, by not just injecting the reading time in front of the feed name, but instead adding a separate column for it.

Looks like this with the standard theme in regular view. Notice the second to last column: grafik

And like this in mobile view: grafik

I also tested it with other themes, without a problem.

lapineige commented 1 year ago

This looks a lot better, thank you for improving this 🙂

Do you agree if I had this change in my own repository, and how do I credit you ? :)

Alkarex commented 1 year ago

Can we merge here so, @lapineige ?

sal0max commented 1 year ago

Glad you like it, @lapineige! No need to credit. Just take the changes however you want.

lapineige commented 1 year ago

@sal0max then I will link to this PR in the commit, to keep track of your improvements ;)

Can we merge here so, @lapineige ?

Yes you can 🙂