Make extensions use typed methods Minz_Request::paramString and Minz_Session::paramString

FreshRSS / Extensions

A repository containing all the official FreshRSS extensions

GNU Affero General Public License v3.0

321 stars 52 forks source link

Make extensions use typed methods Minz_Request::paramString and Minz_Session::paramString #181

Closed mkorthof closed 7 months ago

mkorthof commented 7 months ago

As per short discussion in PR #5830:

https://github.com/FreshRSS/FreshRSS/pull/5830#issuecomment-1816813504 https://github.com/FreshRSS/FreshRSS/pull/5830#issuecomment-1817137233

Tested the 3 extensions with actual changes in docker container running d2aef84827ee freshrss/freshrss:edge:

xExtension-CustomJS
xExtension-CustomCSS
xExtension-ImageProxy

Alkarex commented 7 months ago

Looks good 👍🏻 Would you be able to give a quick try to the extensions, to check that are still running without crash?

mkorthof commented 7 months ago

Looks good 👍🏻 Would you be able to give a quick try to the extensions, to check that are still running without crash?

I'm actually using CustomJS myself so that got the most testing :) It's been working fine so far. Also enabled the other extensions and tested changing settings of the ones that can be configured (CustomJS, CustomCSS, ImageProxy).

No errors in apache or frss logs and no other issues afaict. Using latest docker image (e4e587aeecf5).

mkorthof commented 7 months ago

Did quick test with with Dockerfile-Oldest, no issues.

Alkarex commented 7 months ago

Thanks for the tests 👍🏻