FreshRSS / Extensions

A repository containing all the official FreshRSS extensions
GNU Affero General Public License v3.0
321 stars 52 forks source link

xExtension-ColorfulList not working when only viewing unread messages #183

Closed MarcelVersteeg closed 7 months ago

MarcelVersteeg commented 7 months ago

When I view the unread messages in FreshRSS and have the ColorfulList extension enabled, the messages are not colored, like they are when viewing all messages.

Alkarex commented 7 months ago

Ping @shinemoon

shinemoon commented 7 months ago

@MarcelVersteeg it sounds weird, while ColorfulList supposes to 'colorize' each '.flux_header' despites of read or unread view and actually I double checked and tried also in my side by switch between 'read/unread' view there... it works.

So is it possible you can inspect the ul item in browser to see if the item like below , i.e. background style well applied in your side:

<ul class="horizontal-list flux_header websitefull" style="background: rgba(62, 9, 19, 0.07);">

Or, can you share the theme you are using (or extentions you enabled in parallel there)? Thanks.

MarcelVersteeg commented 7 months ago

Hi @shinemoon

The matter seems to be a little more complicated, but let me first answer your question about the theme: I'm using Alternative Dark.

When I opened my FreshRSS this morning and immediately went to the "Unread" messages (by clicking this button: image ), the list was colored as it was when the complete list was shown.

Then I execeuted the following steps:

  1. At the bottom of the list, click "Mark all as read" (this returned me to the complete list of all messages and they were correctly colored)
  2. Marked some messages as "Unread" (by clicking the envelope in front of the message)
  3. Open the "Unread" messages again (this shows the list of the messages marked as "Unread", but there is no coloring).

In that situation I also checked to see if the style was applied to the item and it wasn't.

As a side question: what colors are being used for the origins? Can I configure that somewhere?

shinemoon commented 7 months ago

Hi, @MarcelVersteeg ,

Thanks, I tried the procedure you addressed, yes, it can be reproduced in my side, and this issue is caused by that the colorization action is not triggered (previously I used the DOM childlist change as trigger for the color generation..) if we proceed as steps you provided.

Now I have one pull request to fix it. Let's see. (maybe @Alkarex you can assign this issue to me ? I then can link and operate there)...

And for your question: "As a side question: what colors are being used for the origins? Can I configure that somewhere?"

It's quite lazy method I am taking, i.e. just using the 'feed name' to generate random color => 'customized color' is not supported...after I consider the effort to be invested vs. the benefit it can bring (and also lazy me..)

Thanks,

Alkarex commented 7 months ago

@MarcelVersteeg please try the updated version by @shinemoon

MarcelVersteeg commented 7 months ago

@shinemoon, @Alkarex I have checked the new version and it now colorizes the items as expected.