FreshRSS / Extensions

A repository containing all the official FreshRSS extensions
GNU Affero General Public License v3.0
321 stars 52 forks source link

Add PHPStan and other quality checks #185

Closed Alkarex closed 7 months ago

Alkarex commented 7 months ago

Similar to FreshRSS core Contributes to https://github.com/FreshRSS/Extensions/issues/184 Uses https://github.com/FreshRSS/FreshRSS/pull/5901

TODO:

Alkarex commented 7 months ago

Only lacking a bit of work on:

Any takers please 🙏🏻? Maybe @Frenzie or @ColonelMoutarde?

This PR can be also merged as-is after a bit of testing. Anyone to give it a try? @lapineige or @math-GH maybe?

Alkarex commented 7 months ago

I thought there was an issue (maybe by @math-GH ) somewhere about doing this PR, but I cannot find it at the moment... (Hints welcome)

lapineige commented 7 months ago

I've no time to test it, sorry.

Frenzie commented 7 months ago

@Alkarex Probably not for a week, slightly depending on the weather.

math-GH commented 7 months ago

Sorry, I am late to the party. In my first check I saw an PHP error with 1.22.2-dev about 10 commits behind. I mean: Does this PR works fine with the current 1.22.1? The users have 1.22.1 installed and add extensions from the repository. Sure that the current extensions (that includes this PR) work fine?

Alkarex commented 7 months ago

No, there is no possible path of update without also making a new FreshRSS release, so we need to issue 1.23.0 as soon as possible. It also indicates the need to have some version ranges for compatibility in the metadata. https://github.com/FreshRSS/FreshRSS/issues/5903 Help very much wanted in finalising the work on the extension updates (tests in particular, before the release of 1.23.0)

xExtension-ImageProxy is also in need of a caring hand (maybe @ColonelMoutarde while @Frenzie is away)

Alkarex commented 7 months ago

What lacks most urgently is testing the compatibility with older third-party extensions, which have not been updated. Edit: this looks ok, at a quick glance (edge, with PHP 7.4, 8.2, 8.3) - more tests welcome

Alkarex commented 7 months ago

Related: https://github.com/FreshRSS/FreshRSS/pull/5837