[Image Proxy] "https://" should be replaced by "ssl:"

mathieumd commented 6 years ago

The proxy configured by default (images.weserv) cannot handle https:// scheme (according to andrieslouw/imagesweserv#33).

You need to replace https:// by ssl: like this:

KO: https://images.weserv.nl/?url=https://freshrss.org/images/freshrss_logo.png (Error 404: Server couldn't parse the ?url= that you were looking for, because it isn't a valid url.)
OK: https://images.weserv.nl/?url=ssl:freshrss.org/images/freshrss_logo.png

Maybe it could be implemented in the fonction line 24 in xExtension-ImageProxy/extension.php?

Frenzie commented 6 years ago

You're saying you also want https images proxied?

mathieumd commented 6 years ago

Wasn't thinking straight that day, I guess! 🤔 Was reading images.weserv doc and went hot about this "missing feature", but it was too early in the morning... ^^ It could be used to prevent webmasters to know when we are reading our feeds, I guess, but I'm not sure if it's really a concern. Closing this one. Sorry for the noise!

FreshRSS / Extensions

[Image Proxy] "https://" should be replaced by "ssl:" #20