Closed math-GH closed 8 months ago
With a little reminder that this is the only remaining extension not passing PHPStan level 9 https://github.com/FreshRSS/Extensions/blob/master/tests/phpstan-next.txt https://github.com/FreshRSS/Extensions/issues/202
Thanks!
@Alkarex
With a little reminder that this is the only remaining extension not passing PHPStan level 9 https://github.com/FreshRSS/Extensions/blob/master/tests/phpstan-next.txt
The line in that file gives me the following result:
find . -type d -name 'vendor' -prune -o -name '*.php' -exec sh -c 'vendor/bin/phpstan analyse --level 9 --memory-limit 512M {} >/dev/null 2>/dev/null || echo {}' \;
./xExtension-ReadingTime/extension.php
./xExtension-QuickCollapse/extension.php
./xExtension-QuickCollapse/Controllers/quickCollapseController.php
./xExtension-QuickCollapse/Models/View.php
./xExtension-showFeedID/extension.php
./xExtension-CustomCSS/extension.php
./xExtension-ShareByEmail/mailers/Share.php
./xExtension-ShareByEmail/extension.php
./xExtension-ShareByEmail/Controllers/shareByEmailController.php
./xExtension-ShareByEmail/Models/View.php
./xExtension-CustomJS/extension.php
./xExtension-ImageProxy/extension.php
./xExtension-TitleWrap/extension.php
./xExtension-StickyFeeds/extension.php
./xExtension-ColorfulList/extension.php
All the errors are about unknown classes.
At a glance I presume that means (some of) these are the actual warnings:
134 Parameter #2 $callback of function preg_replace_callback expects
callable(array<int|string, string>): string, Closure(mixed): array<string> given.
135 Parameter #2 $value of method DOMElement::setAttribute() expects string, string|null
given.
142 Method ImageProxyExtension::setImageProxyHook() has invalid return type FreshRSS_Entry.
142 Parameter $entry of method ImageProxyExtension::setImageProxyHook() has invalid type
FreshRSS_Entry.
Image proxy extension: update to wsrv.nl and add German