search

FreshRSS / Extensions

A repository containing all the official FreshRSS extensions
GNU Affero General Public License v3.0
378 stars 59 forks source link

New extension WordHighlighter - for highlighting words. #238

Closed lukasMega closed 3 months ago

lukasMega commented 6 months ago

init commit for new extension WordHighlighter - for highlighting words.

discussion, how it started: https://github.com/FreshRSS/FreshRSS/discussions/6475

lukasMega commented 6 months ago

currently in this very first version (0.0.1) only one highlighting type (primary) is implemented:

Screen 2024-05-21 at 23 45 27
math-GH commented 6 months ago

Let me know how I can assist you.

lukasMega commented 6 months ago

Let me know how I can assist you.

@math-GH I would appreciate if you go through PHP code because I'm not familiar with PHP ecosystem (I have used PHP probably 10 years ago). Thank you.

Note that I was heavily inspired by extension Custom JS.

After update, config section now looks like:

Screen 2024-05-22 at 22 16 17
lukasMega commented 6 months ago

also I need help with fixing errors from PHPStan. And I don't know how to trigger automated checks via Github Actions / workflows.

math-GH commented 6 months ago

I don't know how to trigger automated checks via Github Actions / workflows.

First-time contributors needs a manual start from an repository admin. I do it for you

Alkarex commented 6 months ago

You can run make test-all locally (this assumes that you have your ./Extensions/ and ./FreshRSS/ folders as siblings (i.e. next to each other in the same directory). See also https://github.com/FreshRSS/Extensions/blob/master/README.md#commands-for-developers

math-GH commented 6 months ago

The TR and FR translations does not to be supported if the translation is not done. English/EN is fine for a start.

lukasMega commented 6 months ago

You can run make test-all locally (this assumes that you have your ./Extensions/ and ./FreshRSS/ folders as siblings (i.e. next to each other in the same directory). See also https://github.com/FreshRSS/Extensions/blob/master/README.md#commands-for-developers

unfortunately I don't have proper DEV environment yet. I just edited files on my live running server (RPi5 via SSH)

The TR and FR translations does not to be supported if the translation is not done. English/EN is fine for a start.

What is the process with translations? Should I delete non English translations? Or should I somehow (with help of Google Translate / DeepL) translate it to other supported languages?

Thank you @math-GH for your help and patience.

math-GH commented 6 months ago

The TR and FR translations does not to be supported if the translation is not done. English/EN is fine for a start.

What is the process with translations? Should I delete non English translations? Or should I somehow (with help of Google Translate / DeepL) translate it to other supported languages?

There is no process at all.

Minimum requirement is to have the EN (English) translation that is the fallback for all other languages.

If you like you could add SK (Slovakian) - as I can see in your profile it could be your native language.

If you would like to have German, French and Dutch as translation then ping @Alkarex , @Frenzie and me.

I would suggest not to use an automatic translation to keep the quality and context.

If someone wants to have his/her language in this extension then the source is open to send a PR ;)

Frenzie commented 6 months ago

In theory machine translation could be a decent starting point (marked as dirty of course), but in practice it'd probably be unnecessarily annoying to have to double check it against the original.

Alkarex commented 3 months ago

Sorry for the delay - I had forgotten about this PR...