search

FreshRSS / Extensions

A repository containing all the official FreshRSS extensions
GNU Affero General Public License v3.0
351 stars 56 forks source link

New extension : add a Reading Time estimation #33

Closed lapineige closed 6 years ago

lapineige commented 6 years ago

See: https://github.com/FreshRSS/FreshRSS/issues/1260

kevinpapst commented 6 years ago

Hi @lapineige, please add it to https://github.com/FreshRSS/Extensions/blob/master/extensions.json as well, then it will be displayed in the admin area as available extension.

Important: the name field must be the same than entrypoint in your metadata.json!

lapineige commented 6 years ago

Ah, good point ! Thanks, I didn't know that was possible.

I'll do it :)

Important: the name field must be the same than entrypoint in your metadata.json! (why ?)

Ok, I'll correct that.

kevinpapst commented 6 years ago

Sorry for the misunderstanding, I meant the name in extensions.json must be the same than entrypoint in metadata.json. But the name in metadata.json is up to you. So you can change it back.

lapineige commented 6 years ago

Well, it doesn't really matter 😄. I leave it like this.

kevinpapst commented 6 years ago

@Alkarex do you prefer to have new extensions hosted in this "official FreshRSS extensions" repository or in their own repository or it doesn't matter?

Alkarex commented 6 years ago

Sorry for the delay (nice weather and all that...). I do not have clear preferences, and it depends on the cases. It could be a kind of progression to first start in their own repositories, and when getting more used / important, to move to this repository, especially when there is more than one developer contributing.

Alkarex commented 6 years ago

@lapineige I have made a few corrections, in particular in the event registration (the script would fail if it was slower than DOMContentLoaded, or faster than jQuery init). Please double-check before we merge.

Here is how it looks on my instance:

image

lapineige commented 6 years ago

Looks good to me. I'll report the changes and test again.

Just to be sure, if you reduce the size of your screen (or if you test on a phone), do you still see the reading time estimation ?

Alkarex commented 6 years ago

When the screen is too small, then the feed titles are not shown, so your reading time disappears as well.

lapineige commented 6 years ago

It should be shown in the title of the article now (you need to reload the page).

lapineige commented 6 years ago

Please double-check before we merge.

It works as expected :)