Closed minami-o closed 5 years ago
Hi, Not at all, I configured vim for python so my tabs were 4 spaces, which was inconsistent with the current code. When I realized this, I used "%s/ /\t/" and didn't see the impact on this line :) Cheers
1 septembre 2018 06:19 "Frans de Jonge" notifications@github.com a écrit:
@Frenzie commented on this pull request.
In xExtension-ImageProxy/extension.php:
@@ -3,7 +3,7 @@ class ImageProxyExtension extends Minz_Extension { public function init() { $this->registerHook('entry_before_display',
- array('ImageProxyExtension', 'setImageProxyHook'));
- array('ImageProxyExtension', 'setImageProxyHook'));Is there a particular rationale behind five tabs?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
Alright, thanks for the addition! If you could remove the final whitespace changes and also edit this:
then I'll merge it. :-)
Thanks!
Thank you for the original piece!
2 septembre 2018 12:22 "Frans de Jonge" notifications@github.com a écrit:
Thanks!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
Hi there, I added a checkbox to ImageProxy in order to enforce the use of the proxy, even for images coming from https sources. The intention is to make the FreshRSS host the only point of contact for the client, preventing direct connection to the RSS sources which could be a privacy concern, or could be blocked by browser addons (for instance µMatrix, when blocking external images except whitelisted hosts). Not sure anyone but me is interested, but well… :) Please let me know if anything should be amended to comply with the extensions' rules. Cheers!