FreshRSS / Extensions

A repository containing all the official FreshRSS extensions
GNU Affero General Public License v3.0
351 stars 56 forks source link

Add "GReader Redate" extension. #79

Closed javerous closed 4 years ago

javerous commented 4 years ago

Add the Greader Redate extension as suggested there https://github.com/FreshRSS/Extensions/issues/72

It's related to the (long) discussion there https://github.com/FreshRSS/FreshRSS/issues/2759

I know that @Alkarex fixed the problem in EasyRSS, but for now I would prefer to keep it in my extension, so the workaround is still possible for those who still use the old version. Perhaps the description can specify a version for EasyRSS ? But there are different forks, if I understand well, so… :s

Frenzie commented 4 years ago

But there are different forks, if I understand well, so… :s

Not really, there's the original abandoned one and the maintained (mainly against bit rot) fork. ;-) Unless you know more?

javerous commented 4 years ago

@Frenzie Not specifically, I just searched on Google, and saw different GitHub results (including the one from @Alkarex). I'm not sure which one is the "new one".

Anyway: @Alkarex if your version is the most maintained (at least, it's the one I tested when I did my tests with the GReader API), I can add the version in the description of extensions.json to make it more explicit.

Something like Workaround a dating problem on GReader API with Reeder and EasyRSS (<= 0.7.5). (the fix is still not merged).

Frenzie commented 4 years ago

Not specifically, I just searched on Google, and saw different GitHub results (including the one from @Alkarex). I'm not sure which one is the "new one".

The others are just random forks in the GH sense (afaik/afaict), not forks in the LibreOffice sense.

Alkarex commented 4 years ago

Regarding EasyRSS, I am waiting to have version 0.7.4 published in F-Droid (mainly a version upgrade of the whole tool stack so that it can compile in current Arduino IDE and current Android), and then merge the PR and issue a new version. This way we have a recent reference to use as a baseline

javerous commented 4 years ago

@Alkarex Do you know which version it will be ? For now I guessed it will be 0.7.5, but perhaps you want to jump to a new minor version, like 0.8.0 ?

Alkarex commented 4 years ago

Probably 0.7.5

javerous commented 4 years ago

@Alkarex There is a problem with the extensions.json no ? I don't see the list anymore in FreshRSS, and I have this log :

2020-06-14 12:14:27
Failed to convert extension file list

I don't think it's the change I did, but can it be related to this ?

{
      "name": "LatexSupport",
      "description": "Add support for LaTeX notation rendering",
      "version": "0.1.2",
      "author": "Alexis Degrugillier",
      "url": "https://github.com/aledeg/FreshRSS-extensions",
    }

(the trailing , at the url + perhaps the type which is missing ?)

Frenzie commented 4 years ago

@javerous JSON rather annoyingly doesn't support simple comments or trailing commas. See https://json5.org/ for what we probably all wish JSON were actually like.

So yes, get rid of that comma. ;-)

Btw, DDG has a built-in JSON validator if you type JSON validator.

Frenzie commented 4 years ago

Oh pardon, I mean add that "type": "gh-subdirectory" since it looks like it was removed by accident, not on purpose. But same difference.

Edit: fixed.