FreshRSS / FreshRSS

A free, self-hostable news aggregator…
https://freshrss.org
GNU Affero General Public License v3.0
9.01k stars 797 forks source link

Impossible to open a link in a new tab on the "clickable link block" if the item is not selected #3120

Closed Massedil closed 2 months ago

Massedil commented 4 years ago

Context :

I sometimes want to open a link in a new tab (right click > open in a new tab) or to copy the article URL without opening the article on FreshRSS.

Actual :

This is not comfortable if the title of the article is short.

Expected :

A screenshot with the zone where the link is clickable (right click > open in a new tab) on Firefox Nightly :

Frenzie commented 4 years ago

While https://github.com/FreshRSS/FreshRSS/issues/2344 is technically about something slightly different, the way https://github.com/FreshRSS/Extensions/tree/master/xExtension-TitleWrap is implemented takes care of that and whatever @marienfressinaud will come up with likely will too.

math-GH commented 1 year ago

It is strange. The <a> is wide enough, but if the article is unread then only the title has the link, the empty space after the title not (but it is still the <a>.

math-GH commented 4 months ago

I would say that this issue was already solved in the past. @Massedil Could you please double check if it is fine now? Thanks!

Massedil commented 4 months ago

I would say that this issue was already solved in the past. @Massedil Could you please double check if it is fine now? Thanks!

Still here for me in 1.21.0.

EDIT : still here in 1.23.1.

math-GH commented 4 months ago

Which theme do you use? Are extensions installed?

Massedil commented 4 months ago

Which theme do you use? Are extensions installed?

Origine — Par : Marien Fressinaud Le thème par défaut pour FreshRSS 8/11

No extension except "Tumblr-GDPR" enabled by default.

Massedil commented 4 months ago

Because of this for the li around the a :

.flux:not(.current):hover .item.title {
  background-color: inherit;
  max-width: calc(100% - 320px);
  position: absolute; /* When hovering it becomes "position: absolute;" and only the text becomes clickable */
}

2024-03-21_15-29 2024-03-21_15-31

math-GH commented 4 months ago

Great. Thanks. I can reproduce it now.

(Side note: I the "TitleWrap" extension is installed and enabled then it is not an issue. Maybe it could help to have a quick workaround)

Alkarex commented 3 months ago

Hum, I cannot reproduce it on my side, with Firefox, Origin theme, no extension

math-GH commented 2 months ago

@Massedil Please test this fix, if possible: #6444

Massedil commented 2 months ago

I tried to use git apply 6444.patch (from here) to quickly update my local code, but I'm on the release channel (1.23.1) and it fails to apply or I miss something. Do you know how I can test and revert it quickly knowing I installed FreshRSS without git ?

math-GH commented 2 months ago

I tried to use git apply 6444.patch (from here) to quickly update my local code, but I'm on the release channel (1.23.1) and it fails to apply or I miss something. Do you know how I can test and revert it quickly knowing I installed FreshRSS without git ?

it is now merged into edge (1.23.2-dev)

Massedil commented 1 month ago

I can confirm this issue is solved in 1.24.0, thanks !