search

FreshRSS / FreshRSS

A free, self-hostable news aggregator…
https://freshrss.org
GNU Affero General Public License v3.0
8.65k stars 771 forks source link

Fix user query filter display #6421

Closed Alkarex closed 1 month ago

Alkarex commented 1 month ago

fix https://github.com/FreshRSS/FreshRSS/issues/6360

math-GH commented 1 month ago

Quite better as before PR.

What I think is not good working right now: "Empty filter" text, if there is no expression and the main stream chosen. grafik

If you select this query f.e. in the view of favorites, than it would jump to the main stream. If you would select this query in the main stream, but you have the "show only unread articles, then it would show unread and read articles after reloading.

One more thought: Does it make sense to keep the "no filter" text? I would say that every query is a valid filter.

If the expression is mandatory then we should mark it as mandatory (via require attribute)

Alkarex commented 1 month ago

The search expression is not mandatory. We could indeed remove the no filter. Let's keep that for another PR, as it is less urgent for 1.24.0.