FreshRSS / FreshRSS

A free, self-hostable news aggregator…
https://freshrss.org
GNU Affero General Public License v3.0
8.77k stars 779 forks source link

Small issues on NOrd Theme #6429

Closed Alwaysin closed 1 month ago

Alwaysin commented 1 month ago

Describe the bug

1/ There is a strange padding at the end of each category:

chrome_rIUryLewQ6

2/ When you click on a cogwheel, either the one for the menu at top right, or one to configure a feed in the feed list, or the arrow right to "Mark as read", all colours change. I understand the logic of it, you often have a dimmed background when opening another windows at the foreground, but it feels off in this case or at least in the way it currently is, you can't distinguish the two states, really, you just see colours changing. Not clicked:

chrome_WZJ6NivZOw

Clicked:

chrome_j9moMASKcJ

To Reproduce

  1. Go to '…'
  2. Click on '…'
  3. Scroll down to '…'
  4. See error

Expected behavior

No response

FreshRSS version

edge

Environment information

Database version: MariaDB 10.11 PHP version: PHP 8.2 Installation type: git -Web server type: Apache Device: Laptop OS: Win11 Browser: Chrome 124

Additional context

No response

math-GH commented 1 month ago

1) it is the color of the scrolling bar. The track and the handle have the same colors as used in the side menu. I would say that choosing a color is a question of taste.

The used CSS variables:

--frss-scrollbar-handle: #0002;
--frss-scrollbar-handle-hover: var(--nord1-polarnight);
--frss-scrollbar-track: transparent;
--frss-scrollbar-track-hover: transparent;

If you want you can optimize it as you want with the CustomCSS extension. Maybe you want to share your improvement too, so we could discuss to take over.

2) I do not understand your described issue or cannot reproduce it. How it looks like for me (Firefox on Win10): sub-mngmt-button-nord-theme

Alwaysin commented 1 month ago

1/ I'm talking about padding at the bottom, not colors.

image

2/ I'm talking about colors of the whole page, the whole background, not colors of "Subscription management" when hovered/clicked. Please do as described: click on the cogwheel on top right, you will see the whole page changing colours.

math-GH commented 1 month ago

Ah ok. Thanks for clarification.

Both thinks works as intended.

1) The paddings gives some space to the next category.

The CSS code, that you could change with the CustomCSS extension:

aside_feed .tree-folder-items.active {
  padding-bottom: 2rem;
}

2) it is a CSS backdrop-filter that grays out the inactive area. It brings the opened dropdown menu in focus. The CSS-Code:

.dropdown-close {
  backdrop-filter: grayscale(25%) brightness(0.9);
}

This resets the backdrop-filter

.dropdown-close {
  backdrop-filter: none;
}
Alwaysin commented 1 month ago

Thank you for the hints to changes in the CSS to make it behave more like I was seeing it!

It brings the opened dropdown menu in focus.

That's the intended effect yes, but in practice it does not work because we are unable to tell apart the two states, it is just confusing to see colours changing slightly. In the end, I agree it is essentially personal preferences so I'm closing this.

math-GH commented 1 month ago

Please feel free to give feedback and improvement ideas