search

Frewacom / pywalfox

Dynamic theming of Firefox (and Thunderbird) using your Pywal colors
https://addons.mozilla.org/en-US/firefox/addon/pywalfox/
Mozilla Public License 2.0
583 stars 12 forks source link

Could not find path to chrome folder when using Beta release of Firefox #32

Open PoorPocketsMcNewHold opened 4 years ago

PoorPocketsMcNewHold commented 4 years ago

Capture d’écran du 2020-05-24 08-38-31 As displayed, Pywalfox isn’t able to found a chrome folder for my firefox-beta profile in which it is running on. Pywall was installed the way it was recommended, after removing the previous native-host setup version that it was previously. You can see it working as expected with the custom Firefox applied colors.

Frewacom commented 4 years ago

This is currently not supported. In the future I might look in to a better solution for getting the correct profile path.

If you still want to use the included CSS sheets, you will have to copy them over manually for now. They are located in <python-site-packages>/pywalfox/assets/css/

Frewacom commented 4 years ago

Actually, it seems like the fix for this might be quite simple. What does your ~/.mozilla/firefox/profiles.ini look like?

PoorPocketsMcNewHold commented 4 years ago

It was (well, it still is, but i´ve stopped using firefox currently) :

Name=default-beta
IsRelative=1
Path=tlbv69uw.default-beta

[Install4F96D1932A9F858E]
Default=56nb3rjl.default-release
Locked=1

[Profile1]
Name=default
IsRelative=1
Path=vblgd07z.default
Default=1

[Install93CE7A4EFF650F31]
Default=tlbv69uw.default-beta
Locked=1

[Profile0]
Name=default-release
IsRelative=1
Path=56nb3rjl.default-release

[General]
StartWithLastProfile=1
Version=2

[Install6BA5C87ECB35E12F]
Default=d9vr4fx3.default-nightly
Locked=1

[Profile2]
Name=default-nightly
IsRelative=1
Path=d9vr4fx3.default-nightly

The other default.nightly and release are remains of older installations, however, despite this, you can see the correct folder is still presented as the first one in the list.

Frewacom commented 4 years ago

Well, it seems like there is nothing that actually indicates which is the current profile. I know there is a way to get the profile path from inside Firefox, but it requires permissions that Pywalfox does not have.

It seems like the only solution to getting it to work consistently is to let the user select the correct profile from the Settings page of the extension.

This will require a decent amount of work involving changes to both the native application and addon, so it is not something I will implement right now.