search

Frewacom / pywalfox

Dynamic theming of Firefox (and Thunderbird) using your Pywal colors
https://addons.mozilla.org/en-US/firefox/addon/pywalfox/
Mozilla Public License 2.0
583 stars 12 forks source link

Thunderbird support #38

Closed fubarhouse closed 3 years ago

fubarhouse commented 3 years ago

Given Mozilla Thunderbird is very closely aligned to Firefox - I would love for it to have a similar experience/look. Just putting this out there as I've no idea what would be involved - but has this been requested before?

Frewacom commented 3 years ago

It seems like Thunderbird version >= 68 uses WebExtensions and therefore supports both the Theming API and native communication API, so I assume it should work.

I am not sure how much work is needed, but I will take a look.

Frewacom commented 3 years ago

I installed pywalfox as a temporary addon in Thunderbird and everything seems to be working with no modifications. It has been uploaded to the Thunderbird addon store.

The only issue I found is that if you are running Firefox and Thunderbird at the same time, two daemons will launch and only one of them will change theme when you run pywalfox update.

Let me know if something is not working properly.

fubarhouse commented 3 years ago

Superb, thank you! 🎉 I'll test this tomorrow s as me let you know how it goes!

fubarhouse commented 3 years ago

This is working exactly as I hoped, so thank you very much! Feel free to close the issue now 😄

edit: I would hope that this tiny little daemon issue could be resolved long term, but it's such a minor thing.

Frewacom commented 3 years ago

The update issue should be fixed in daemon version 2.5. You can update using pip.

Closing this for now.

mtoohey31 commented 3 years ago

Just one note on this, at least for me, I had to put the native messaging host .json in the global visibility location for MacOS as explained in this article: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_manifests When it was just in the per-user Thunderbird didn't find it for some reason.

Frewacom commented 3 years ago

Just one note on this, at least for me, I had to put the native messaging host .json in the global visibility location for MacOS as explained in this article: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_manifests When it was just in the per-user Thunderbird didn't find it for some reason.

I added a --globalflag to the Pywalfox CLI that can be used to install the manifest globally, rather than just locally. It has not been pushed to pip yet, but I will do that eventually. I'll also make sure this gets added to the Troubleshooting guide, in case someone else has the same issue.