Frewacom / pywalfox

Dynamic theming of Firefox (and Thunderbird) using your Pywal colors
https://addons.mozilla.org/en-US/firefox/addon/pywalfox/
Mozilla Public License 2.0
583 stars 12 forks source link

Alter pallete with command? #43

Closed GideonWolfe closed 3 years ago

GideonWolfe commented 3 years ago

I am the author of Chameleon, a tool for theming your system with one command. We have spoken before :)

I successfully have automated pywalfox with a simple pywalfox update hook.

However, there are some settings that I always apply, which get reset every time new colors are fetched. This forces me to manually change it, breaking the seamless automation.

So my question is, are there any exposed commands that could accomplish this? The specific setting I am referring to is changing Background Extra to be the same color as Background, as I just think that looks better.

Thanks!!

Frewacom commented 3 years ago

There are currently no commands available that allows you to change this from the terminal.

However, you can modify the Palette template in the Settings page. It allows you to specify which pywal color (index 0-15) should be used when setting a certain color, e.g Background extra. If you want it to be the same as the Background color you just have to set them to the same index. All changes you make in the templates are persistent between fetches (though there are separate templates for light and dark mode).

There is also a Theme template which allows you to change which color should be used for a certain element of the browser, so that is also an option if you still want to keep Background extra on certain elements.

If you would prefer using a command to modify this, I’ll consider adding that in the future.

GideonWolfe commented 3 years ago

Ah, the template settings are just what I was looking for, as long as it stays persistent across refreshes :)

Would you be able to help me isolate this one element? I checked the visual guide you linked but nothing points directly to it, and I was messing with many of the template variables with no impact.

image

It seems to be a toolbar* variable, but I can't pin down which one. All I know is it gets fixed when I just change background extra -> background across the board.

Frewacom commented 3 years ago

I am not quite sure. For me, just updating the Toolbar field property updates the background of the entire url bar. I tried with and without the included CSS with the same result.

GideonWolfe commented 3 years ago

Ah, it would seem I didn't notice the Save Template button right in front of my face. I was confused because other changes (like altering colors in the main pallet) take effect immediately. But it makes sense to have to "Save" a template.

Thanks!

Frewacom commented 3 years ago

You're welcome :)

The "Save" button could probably be removed. As you say, it would be more intuitive to update the theme directly, since that is the behaviour for most other settings.

I'll close this for now and consider fixing that in a future update.