Frewacom / pywalfox

Dynamic theming of Firefox (and Thunderbird) using your Pywal colors
https://addons.mozilla.org/en-US/firefox/addon/pywalfox/
Mozilla Public License 2.0
583 stars 12 forks source link

Need to manually refresh pywalfox when I open firefox #57

Open GideonWolfe opened 3 years ago

GideonWolfe commented 3 years ago

Hello, I'd just like to report an issue I've been having recently.

When I open Firefox, some of the aspects of pywalfox I customized are not applied until I manually open the pywalfox settings menu and click "Fetch Pywal Colors". Could there be a reason these are not applied on launch anymore?

Frewacom commented 3 years ago

It sounds like a bug. What exactly is not being applied?

GideonWolfe commented 3 years ago

Hmm, I filmed this gif to demonstrate what changes, but then I noticed that I didn't have the automatically fetch colors option checked.

I definitely didn't uncheck it manually, as it is unchecked on multiple devices. Must be a settings reset of some sort? 1610383833

It was really only the dropdown backgrounds (which I had changed manually to match the regular backgrounds) and the toolbar icons, and the borders on the searchbar (that I also changed to background color).

So I think it should be working now but I'll re-open if not.

GideonWolfe commented 3 years ago

Hmm, so the issue seems to persist. So here is what it looks like when I inititally open FireFox:

image

Note the "Fetch colors on startup" option is set to "Yes", yet the sides of my searchbar and my toolbar icons are the wrong colors. Backgrounds of dropdowns are also wrong but I couldn't screenshot without taking away focus and hiding them.

After manually pressing "Fetch Pywal colors", it looks as it should

image

Frewacom commented 3 years ago

That is weird. When did you first notice this issue?

GideonWolfe commented 3 years ago

About a month ago.

Frewacom commented 3 years ago

Could there be any custom CSS that might interfere? The "Fetch colors on startup" option is equivalent with clicking on "Fetch Pywal colors", so I don't see any reason as to why it would not work as expected. The only difference that I can think of is that the option fetches and sets the theme as soon as addons are loaded by Firefox.