search

Frezyx / sidebarx

Flutter multiplatform navigation sidebar / side navigation bar / drawer widget
https://pub.dev/packages/sidebarx
MIT License
292 stars 48 forks source link

Sidebar menu items not occupying the whole height available #31

Closed melchorlapinigjr closed 1 year ago

melchorlapinigjr commented 1 year ago

Describe the bug I noticed when I upgraded to sidebarx 0.13.0, the menu items are not occupying the whole height available in the view.

To Reproduce Steps to reproduce the behavior:

  1. Upgrade to version 0.13.0
  2. Put 8 sidebar items
  3. Run in Google Chrome

Screen recording https://user-images.githubusercontent.com/40294247/194965229-665de925-13be-4bd3-80e9-a9a1b0997ed4.mp4

Desktop (please complete the following information):

Frezyx commented 1 year ago

Hello @melchorlapinigjr ! I see this bug.

We need to add this line of code on 146 line to fix the situation.

if (widget.footerItems.isNotEmpty)

telegram-cloud-photo-size-2-5343667369471492408-y

Frezyx commented 1 year ago

I'am without notebook now. I will be able to release fixes only tomorrow 😢

melchorlapinigjr commented 1 year ago

@Frezyx No worries mate. Thanks for this quick work around. Cheers!

Frezyx commented 1 year ago

@melchorlapinigjr Hello you can check fix in 0.14.0 version