search

FriedrichFroebel / pelican-youtube-thumbnails

Pelican plugin to link to YouTube videos by their thumbnail
GNU Affero General Public License v3.0
1 stars 0 forks source link

Warning about strip_cdata parameter during the tests #7

Open FriedrichFroebel opened 2 months ago

FriedrichFroebel commented 2 months ago

Running the tests yields a warning from lxml about the strip_cdata parameter. I am not aware that I am using it anywhere, thus it should be debugged where it is coming from to get rid of the warning.

test_add_image_overlay (test_youtube_thumbnails.YoutubeThumbnailsPluginTestCase.test_add_image_overlay) ... ok
test_create_html_for_image (test_youtube_thumbnails.YoutubeThumbnailsPluginTestCase.test_create_html_for_image) ... ok
test_get_logo_file (test_youtube_thumbnails.YoutubeThumbnailsPluginTestCase.test_get_logo_file) ... ok
test_get_output_file (test_youtube_thumbnails.YoutubeThumbnailsPluginTestCase.test_get_output_file) ... ok
[06:53:28] WARNING  /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3 log.py:89
                    .12/site-packages/bs4/builder/_lxml.py:124:                 
                    DeprecationWarning: The 'strip_cdata' option of             
                    HTMLParser() has never done anything and will               
                    eventually be removed.                                      
                      parser = parser(                                          

test_replace_youtube (test_youtube_thumbnails.YoutubeThumbnailsPluginTestCase.test_replace_youtube) ... ok
test_replace_youtube__additional_values (test_youtube_thumbnails.YoutubeThumbnailsPluginTestCase.test_replace_youtube__additional_values) ... ok
test_replace_youtube__static (test_youtube_thumbnails.YoutubeThumbnailsPluginTestCase.test_replace_youtube__static) ... ok
test_save_thumbnail__with_overlay (test_youtube_thumbnails.YoutubeThumbnailsPluginTestCase.test_save_thumbnail__with_overlay) ... ok
test_save_thumbnail__without_overlay (test_youtube_thumbnails.YoutubeThumbnailsPluginTestCase.test_save_thumbnail__without_overlay) ... ok
FriedrichFroebel commented 2 months ago

This is a bug in beautifulsoup4 which has been fixed, but is unreleased. Upstream references: https://bugs.launchpad.net/beautifulsoup/+bug/2076897 https://git.launchpad.net/beautifulsoup/commit/?id=9786a62726de5a8caba10021c4d4a58c8a3e9e3f

I am going to keep this open until I have verified that a new release of beautifulsoup4 has been pushed to PyPI which includes this fix.