Friend-LGA / LGSideMenuController

iOS view controller which manages left and right side views
MIT License
2.05k stars 331 forks source link

Inconsistency between pod and repository? #160

Closed ilTrev closed 3 years ago

ilTrev commented 6 years ago

While building a project including the pod, I am receiving three warnings about block declarations not being prototypes in LGSideMenuController.h, LGSideMenuHelper.h and LGSideMenuView.h.

Since the solution would be quite easy to implement, I cloned the repository to create a branch and do that on my own, but I see that the master branch of the repo does not match the pod. Specifically, these three warnings have already been fixed, even if the version (2.1.1) appears to be the same both in pod and repository.

Am I missing something? Anything I could do to fix the issue (apart from manually importing the framework)?

The incriminated lines of code are:

LGSideMenuController.h: (pod) typedef void (^ _Nullable LGSideMenuCompletionHandler)(); (master) typedef void (^ _Nullable LGSideMenuCompletionHandler)(void);

LGSideMenuHelper.h: (pod) + (void)animateWithDuration:(NSTimeInterval)duration animations:(void(^)())animations completion:(void(^)(BOOL finished))completion; (master) + (void)animateWithDuration:(NSTimeInterval)duration animations:(void(^)(void))animations completion:(void(^)(BOOL finished))completion;

LGSideMenuView.h: (pod) - (nonnull instancetype)initWithLayoutSubviewsHandler:(void(^ _Nonnull)())layoutSubviewsHandler; (master) - (nonnull instancetype)initWithLayoutSubviewsHandler:(void(^ _Nonnull)(void))layoutSubviewsHandler;

ilTrev commented 6 years ago

Ok, I just got it and it makes sense: the fix was applied in commit bf193b2 and merged in 7aa3232, but no version bump and tag were applied. Any chance this can be done by someone?

ethanwa commented 5 years ago

Really hoping someone can do this soon.

Friend-LGA commented 3 years ago

Done