search

Friend-LGA / LGSideMenuController

iOS view controller which manages left and right side views
MIT License
2.05k stars 331 forks source link

Nav bar appears under notch on iPhone X, 11 Pro #174

Closed CMoebius closed 3 years ago

CMoebius commented 5 years ago

I am having a problem with our rollout of iOS 13 changes and I have been running on devices with a notch (iPhone X & iPhone 11 Pro). The nav bar in our app is appearing under the notch on those devices, so I looked at the demo app and found it doing the same thing. Is there an issue with LGSideMenu for devices with a notch or is the demo and our app not doing something that it needs to to account for the notch?

CMoebius commented 5 years ago

To be clear, the problem occurs when selecting an item from the left menu to display the new controller "full-screen". That's when the nav bar appears under the notch. It appears that the method LGSideMenu uses to present the new view controller is not doing something it shouldn't.

CMoebius commented 5 years ago

Another piece of information: when I use LGSideMenuPresentationStyleScaleFromBig or LGSideMenuPresentationStyleScaleFromLittle this anomaly happens. When I use LGSideMenuPresentationStyleSlideAbove or LGSideMenuPresentationStyleSlideBelow the nav bar is not under the notch.

iamsanketray123 commented 4 years ago

Facing same issue after iOS 13... any fix?

Friend-LGA commented 3 years ago

Should be fixed now. Fell free to reopen if the issue is still actual.