FriendCode / gittle

Pythonic Git for Humans
Other
732 stars 90 forks source link

diff() branch problem #31

Closed Radymus closed 10 years ago

Radymus commented 10 years ago

When i tried this library i hit to one problem. If the repository doesn't have master branch, method diff returns keyException. So i suggest add another argument to diff to set branch. This problem can be bypassed setting Gittle.DEFAULT_BRANCH but this is ugly solution.

gmt commented 10 years ago

Clearly the DEFAULT_BRANCH constant is a hack that won't work in plenty of real-world situations. It should probably become a dynamically computed property of the Repo instance. I'd have done this myself, but, tbh, I haven't yet figured out exactly where git canonically saves the corresponding porcelain setting... if nobody around here knows, someone may have to chase that information down in the git source code.