FriendCode / gittle

Pythonic Git for Humans
Other
732 stars 90 forks source link

fixed some error in Python3 #77

Closed gsw945 closed 8 years ago

gsw945 commented 8 years ago

2 modules urlparse and StringIO import changed in Python 3.

040000 in Python 2, changed to 0o40000 in Python 3

basestring is not defined in Python 3, replaced with str

hanbeibei commented 8 years ago

does these change work? why there are some import error that need to be fixed,

I had tried but not fixed, please refer to this: http://stackoverflow.com/questions/12172791/changes-in-import-statement-python3

maybe I still need more time to figure out the python 3 module import mechanism

hanbeibei commented 8 years ago

the problem which I met: File "C:\Python33\lib\site-packages\gittle-0.2.1-py3.3.egg\gittle\utilsinit.py", line 1, in < module> from . import paths, urls, git

there are some describe on issue 12, but I was in mac, and install with pip, there no error during installation process, it should not be happened

hanbeibei commented 8 years ago

maybe we need this future: https://docs.python.org/3/library/__future__.html?highlight=__future__#module-__future__

AaronO commented 8 years ago

@gsw945 Thanks :+1: