Closed bzreinhardt closed 6 years ago
LGTM
On Sun, May 20, 2018 at 5:11 PM Benjamin Reinhardt notifications@github.com wrote:
Working firebase listener. Tests: Refresh with wifi off successfully reinserts data Adding person in incognito window triggers refresh with that person in non-incognito window.
You can view, comment on, or merge this pull request online at:
https://github.com/FriendForce/friendforce/pull/38 Commit Summary
- working persistence
- working automatic firebase listener
File Changes
- M my-app/src/App.js https://github.com/FriendForce/friendforce/pull/38/files#diff-0 (18)
- M my-app/src/DataStore.jsx https://github.com/FriendForce/friendforce/pull/38/files#diff-1 (141)
- M my-app/src/TestStuff.jsx https://github.com/FriendForce/friendforce/pull/38/files#diff-2 (5)
Patch Links:
- https://github.com/FriendForce/friendforce/pull/38.patch
- https://github.com/FriendForce/friendforce/pull/38.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FriendForce/friendforce/pull/38, or mute the thread https://github.com/notifications/unsubscribe-auth/ACIDXaKRxmxPmuZXi1sqG1qU3Vg_F2Caks5t0gYbgaJpZM4UGSSD .
Working firebase listener. Tests: Refresh with wifi off successfully reinserts data Adding person in incognito window triggers refresh with that person in non-incognito window.