search

FriendForce / friendforce

1 stars 0 forks source link

[Feature/Complete] Login through Google (w/ logout) #41

Closed hackgoofer closed 6 years ago

hackgoofer commented 6 years ago
screen shot 2018-05-23 at 9 41 01 pm
hackgoofer commented 6 years ago
  1. I don't think names should be human readable. That's unscalable.
  2. Later PR.
bzreinhardt commented 6 years ago

1) How is it not scalable? last name, first name, number. 2) If later PR than leave in the flag

hackgoofer commented 6 years ago
  1. What if they don't have unix names? A hash is way easier.
  2. Creating a new person upon login as a user is a new feature. Leaving in the flag is messy, this does not break functionality.
hackgoofer commented 6 years ago

I agree google uid probably shouldn't be somebody's id, but i disagree on the id needing to be readable.

bzreinhardt commented 6 years ago

http://friendforce.app/person/sasha_sheng123 is way better than http://friendforce.app/person/2ghf1-298hr20338f3h3ge17

Beautiful URLs are important

hackgoofer commented 6 years ago

I see, forgot about the fact that it is being used as a route.