As of 5dda5e09ca54a48d3b26a7743a1ba5abfbcb763f, VODs now includes all videos on a channel. This means that "ARCHIVE" (previous full streams), "HIGHLIGHT" (segments from a previous stream), "UPLOAD" (channel owner uploaded content), and "PAST_PREMIERE" (channel owner uploaded content as a live stream) broadcast types are now saved into the vod directory. These should be separated out into their own directories and settings, separate from just "ARCHIVE" types which is what VOD originally referred to in VodBot's vocabulary.
Proposal:
New directories for each type of video. vods will remain as the "ARCHIVE" type. highlights and uploads match their respective types. premieres goes with "PAST_PREMIERE", which is specifically a type of upload that is showcased as a live stream; not a rerun stream.
Each new type of video should be treated like a VOD when downloading, but things like print statements and logic should be able to distinguish them.
QUESTION: should queries to twitch pull all the videos at once and sort them locally, or do individual queries about different videos.
QUESTION: When querying, should videos stop being queried for if the first previously cached video is found? I believe videos are paged from newest to oldest, but can we be certain about that?
ANSWER: after looking at twitch.py, yes returned videos are sorted by time. Yes, videos should stop being queried for when the first locally available video is found.
As of 5dda5e09ca54a48d3b26a7743a1ba5abfbcb763f, VODs now includes all videos on a channel. This means that "ARCHIVE" (previous full streams), "HIGHLIGHT" (segments from a previous stream), "UPLOAD" (channel owner uploaded content), and "PAST_PREMIERE" (channel owner uploaded content as a live stream) broadcast types are now saved into the vod directory. These should be separated out into their own directories and settings, separate from just "ARCHIVE" types which is what VOD originally referred to in VodBot's vocabulary.
Proposal:
vodswill remain as the "ARCHIVE" type.highlightsanduploadsmatch their respective types.premieresgoes with "PAST_PREMIERE", which is specifically a type of upload that is showcased as a live stream; not a rerun stream.QUESTION: When querying, should videos stop being queried for if the first previously cached video is found? I believe videos are paged from newest to oldest, but can we be certain about that?twitch.py, yes returned videos are sorted by time. Yes, videos should stop being queried for when the first locally available video is found.