FriendlyCaptcha / friendly-challenge

The widget and docs for the proof of work challenge used in Friendly Captcha. Protect your websites and online services from spam and abuse with Friendly Captcha, a privacy-first anti-bot solution.
https://friendlycaptcha.com
MIT License
414 stars 61 forks source link

Hebrew translations #232

Closed tinytim84 closed 1 year ago

tinytim84 commented 1 year ago

We'd like to use FriendlyCaptcha on our Hebrew translated site, and we're happy to provide the translations, but before we get them I wanted to ask whether FriendlyCaptcha supports RTL languages?

gzuidhof commented 1 year ago

Hi Tim,

That would be great. The widget should work fine in RTL mode. If necessary you can add custom CSS rules, but by trying it myself it seems to work fine with the following:

.frc-captcha {
  direction: rtl;
}

That makes me hopeful that no further changes would be required.

If we find that some changes are required, I'd be happy to help and we can incorporate them in this library.

gzuidhof commented 1 year ago

Screenshot 2023-10-11 at 14 57 48

Here is a screenshot of the widget in RTL. The only small tweak that perhaps makes sense is small tweaks to the padding/margin (the button touches the left side), but that is only aesthetical.

tinytim84 commented 1 year ago

Great, thank you. I'll get on the translations and provide them here.

tinytim84 commented 1 year ago

@gzuidhof I have the translations in an excel file. If I paste them here it doesn't strictly keep the RTL nature of the text. What do you suggest for me getting them to you? Can I email them to an address?

gzuidhof commented 1 year ago

You could try to create a gist (https://gist.github.com) and share that. If that doesn't work, you can e-mail them to me (<firstname>@friendlycaptcha.com)

Thank you!

tinytim84 commented 1 year ago

That still flipped some of the bits. I've emailed the excel file to you. Please let me know when the translations are in.

gzuidhof commented 1 year ago

I created a PR here :) https://github.com/FriendlyCaptcha/friendly-challenge/issues/234

gzuidhof commented 1 year ago

It's now live in 0.9.14 :)