search

FriendlyCaptcha / friendly-lite-server

Lite server for Friendly Captcha
https://friendlycaptcha.com
Other
43 stars 12 forks source link

Add docker based setup #12

Closed R0Wi closed 1 year ago

R0Wi commented 1 year ago

Closing #11

amenk commented 1 year ago

Thanks a lot, can you solve the conflicts?

R0Wi commented 1 year ago

Thanks a lot, can you solve the conflicts?

Done @amenk . I needed to adjust quite a few lines in Env.template so I decided to add some tests in a separate commit (9ba7732424874930324ea4327b531f1758e93f27). Please let me know if this is okay for you or if you'd rather like me to create a separate PR for this.

Tested the Docker setup and still seems to work 😄

amenk commented 1 year ago

Having so much code in the Env.template does not sound very elegant.

Thanks @R0Wi - now that we have composer in place we might as well use dotenv ...

But it's fine for now :-)

R0Wi commented 1 year ago

Using an external library like dotenv sounds definitely cleaner and it will reduce the code quite a bit. If you're interested I could create a PR for this aswell. We should just discuss how to bootstrap composer in that case. Would you like to leave it to the admin to install the dependencies via composer install or would you prefer to commit the vendor folder?

amenk commented 1 year ago

Would leave that to the admin, vendor/ should not be commited ..

In the end of the day it would be nice to be able to use this also as a dependency in PHP projects but as well as standalone .. not sure how well this is possible :-)

R0Wi commented 1 year ago

Sounds good 👍

Think that should be possible somehow, let's see 😄