search

FriendlyDotCH / mautic-multi-domain

MIT License
38 stars 18 forks source link

Fatal Error Activating Mautic 5 #23

Closed andrewfitz closed 7 months ago

andrewfitz commented 7 months ago

Hi, first time using this, would not install via composer, so used zip. When clearing cache came to this error:

PHP Fatal error: Declaration of MauticPlugin\MauticMultiDomainBundle\MauticMultiDomainBundle::onPluginInstall(Mautic\PluginBundle\Entity\Plugin $plugin, Mautic\CoreBundle\Factory\MauticFactory $factory, $metadata = null, $installedSchema = null) must be compatible with Mautic\PluginBundle\Bundle\PluginBundleBase::onPluginInstall(Mautic\PluginBundle\Entity\Plugin $plugin, Mautic\CoreBundle\Factory\MauticFactory $factory, $metadata = null, $installedSchema = null): void in /plugins/MauticMultiDomainBundle/MauticMultiDomainBundle.php on line 14

wldpaul commented 7 months ago

Changing line 13 of MauticMultiDomainBundle.php to: public static function onPluginInstall(Plugin $plugin, MauticFactory $factory, $metadata = null, $installedSchema = null): void stops the above error; but the plugin does not show up when scanning for new ones in 5.0.2

jos0405 commented 7 months ago

Thank you for your feedback.

This plugin is for Mautic 4. We'll announce once the upgade is done.