search

FriendlyDotCH / mautic-multi-domain

MIT License
37 stars 18 forks source link

Update for V5? #29

Open ElectricMediaUK opened 2 months ago

ElectricMediaUK commented 2 months ago

Hello!

Do you have any intention to update the multi-domain plug-in to work with version 5 Mautic?

I hope you do however please can you respond to confirm?

Thanks

sheddingmyskin commented 1 month ago

Seconding this request.

miamicityman commented 1 month ago

Bumping request / question.

clicksmartmedia commented 5 days ago

I tried to use this and you just get an error when you install:

[Mon Aug 19 23:58:49.334861 2024] [proxy_fcgi:error] [pid 2958990:tid 2958990] [client 162.157.115.237:57508] AH01071: Got error 'PHP message: PHP Fatal error: Cannot make static method Mautic\\PluginBundle\\Bundle\\PluginBundleBase::onPluginInstall() non static in class MauticPlugin\\MauticMultiDomainBundle\\MauticMultiDomainBundle in /var/www/.ly/docroot/plugins/MauticMultiDomainBundle/MauticMultiDomainBundle.php on line 14; PHP message: PHP Notice: Cannot make static method Mautic\\PluginBundle\\Bundle\\PluginBundleBase::onPluginInstall() non static in class MauticPlugin\\MauticMultiDomainBundle\\MauticMultiDomainBundle - in file /var/www/.ly/..ly/docroot/plugins/MauticMultiDomainBundle/MauticMultiDomainBundle.php - at line 14; PHP message: Symfony\\Component\\ErrorHandler\\Error\\FatalError: Notice: Cannot make static method Mautic\\PluginBundle\\Bundle\\PluginBundleBase::onPluginInstall() non static in class MauticPlugin\\MauticMultiDomainBundle\\MauticMultiDomainBundle - in file /var/www/./..ly/docroot/plugins/MauticMultiDomainBundle/MauticMultiDomainBundle.php - at line 14', referer: https://..//contacts The "app/bundles/CoreBundle/Resources/views/Offline" directory does not exist ("//app/bundles/CoreBundle/Resources/views/Offline"). Then if you move it out of the directory or delete it works.

Tried to update MauticMultiDomainBundle.php to this...

class MauticMultiDomainBundle extends PluginBundleBase
{
    public static function onPluginInstall(Plugin $plugin, MauticFactory $factory, $metadata = null, $installedSchema = null): void

And it seems to not crash now, but Mautic won't recognize the plugin.