search

FriendlyNeighborhoodShane / MinMicroG

Sources and scripts for MinMicroG installers. You shall find no prebuilt releases here.
GNU General Public License v3.0
315 stars 33 forks source link

Alter OTA build process, so built Magisk modules work with KernelSU #53

Closed zer0def closed 1 year ago

zer0def commented 1 year ago

Due to how KernelSU installs modules, module.prop has to be pre-populated in the OTA for the process to start.

FriendlyNeighborhoodShane commented 1 year ago

Hiya, long time no see!

Thanks for making this, there's another issue open about it too: https://github.com/FriendlyNeighborhoodShane/MinMicroG/issues/50

Is this the only change required to make it install with kernelSU? The person there also mentions it needing a customise.sh to run.

As I mention there, the support for booted installs need to be improved, and I'm planning to move the cleanup steps to early boot, but that's a second step.

zer0def commented 1 year ago

I've just tested by installing, running and uninstalling on Magisk's canary 26104 and on KernelSU, that module.prop drop-in is all it really needs, especially since this module operates as an overlay module, though it did require extra user-app uninstallation on Magisk post-uninstallation, but nothing game-changing.

FriendlyNeighborhoodShane commented 1 year ago

Looks good then, thanks! Will trigger CI in a bit.