search

FriendlyNeighborhoodShane / MinMicroG

Sources and scripts for MinMicroG installers. You shall find no prebuilt releases here.
GNU General Public License v3.0
315 stars 33 forks source link

PlayStore still remains #56

Closed ghost closed 10 months ago

ghost commented 1 year ago

i installed MinAddon-Playstore-Playstore-2.12.0-20230729205900.zip as magisk module

then deleted it, but the playstore app is still installed. even after i removed magisk.

FriendlyNeighborhoodShane commented 1 year ago

That's just a regular user app, you can simply uninstall it. Playstore and GMS have to be installed as a user app update over the system overlays because android is fussy about certain permissions otherwise.

ghost commented 1 year ago

That's just a regular user app, you can simply uninstall it.

Yes, it's just a regular user app. And it should be easier to just hit the "uninstall" button But there is no "uninstall" option, only "disable".

To uninstall can only be done via adb. adb shell pm uninstall com.android.vending

This reminds me of microg installer revived issue Fixed by adding this

To clarify, this happened after the play store got an update. If i remove the module before play store gets update then no problem at all.

thanks.

FriendlyNeighborhoodShane commented 1 year ago

My bad, the mobile UI isn't suited for my butter fingers.

That's just a regular user app, you can simply uninstall it. Yes, it's just a regular user app. And it should be easier to just hit the "uninstall" button But there is no "uninstall" option, only "disable".

That's weird. That means it's still a system app. Are you sure it wasn't a system installation? That would explain why it didn't go away with magisk. Or you might have a system install that was lying below the magisk install all along.

If the minmicrog/addon packages are flashed in recovery without a decrypted data, they have no way to detect the existence of an older version of itself, or even magisk, so by default it installs to system.

ghost commented 1 year ago

That means it's still a system app.

It seems like.

Are you sure it wasn't a system installation?

Fresh install LineageOS for microG + Magisk... twice The addon is installed using Magisk Manager.

I don't even use recovery at all. The reason I installed it using Magisk is because I can't install it using recovery. Due to an error not enough storage on the system or something like that. I forgot the error message.

That would explain why it didn't go away with magisk.

As what I said before. If the module is removed from magisk manager before playstore gets an automatic update. The problem does not occur.

FriendlyNeighborhoodShane commented 1 year ago

Hi, Sorry for the late reply. Not sure what's causing this behaviour then. Is playstore promoting itself to a pseudo-system app? Or is this a bug in android?

ghost commented 1 year ago

Hi. I also experienced something similar.

Expected Behavior When the module is removed the play store should disappear.

Current Behavior Play store is still left untouched.

Steps to Reproduce

  1. Install LineageOS for microG.
  2. Install Magisk.
  3. Install MinAddon-Playstore-Playstore-2.12.0-20230729205900.zip as module.
  4. Open F-Droid.
  5. Update microG Services Core to version 0.2.28.231657.
  6. Open Play Store.
  7. Update Play Store version (manual or automatic).
  8. Open Magisk.
  9. Remove MinAddon-Playstore-Playstore-2.12.0-20230729205900.zip module.
  10. Reboot.

Play Store is still there. Even uninstalling magisk completely. Play Store is still there.

The only way to get rid of Play Store is to factory reset.

Device information Redmi 9 (Lancelot). LineageOS for microG lineage-20.0-20230810-microG-lancelot.zip

ghost commented 1 year ago

@FriendlyNeighborhoodShane

I also can't install through recovery.

!!! FATAL ERROR: Not enough free space in your /mnt/system!

Stopping installation and Uninstalling...

Installation failed!

ERROR: recovery: Error in /sideload/package.zip (status 1)

last_log.txt

FriendlyNeighborhoodShane commented 1 year ago

I guess I'll reopen this issue, though I'm still not sure how this is caused. I'll try to reproduce it, and see if adding the pm uninstall command would fix it. Though it could only be run on Magisk uninstalls, not on system.

FriendlyNeighborhoodShane commented 1 year ago

About the free space thing, the answer lies in the log you posted:

[  636.226897] Pack size is 156
[  636.248079] Free space in /mnt/system is 2

These sizes are in MBs. You have a dynamic partition layout where there's no space reserved in /system for user mods. Your ROM maintainer can fix this: https://github.com/FriendlyNeighborhoodShane/MinMicroG/issues/19#issuecomment-918548245