search

Friends-of-Monika / mas-selfharm

💛 Submod about self-harm for MAS
https://mon.icu/discord
Other
3 stars 1 forks source link

Bug: milestone topics are repeating constantly #41

Closed dreamscached closed 3 weeks ago

dreamscached commented 3 weeks ago

What happened?

[Reported several times both on Reddit and Discord] On first week (most probably also on following milestones too) the topic seems to loop indefinitely.

Also re-occurrence of #34.

Traceback output

No response

Submod version

2.0.3 to 2.0.4

Monika After Story version

latest

Unstable

No

dreamscached commented 3 weeks ago

Something keeps queueing the milestones to the MASEventList, and we should add checks to de-duplicate the queued events and remove them from the list. Additionally we need checks in every milestone event to ensure we aren't looping (addressed in c617d71fa385798bec39e9d200faf8a6e1573498)

Another possible cause is that we use ch30_loop instead of ch30_day for whatever reason. This was addressed in 7cebe69a62a7a38b7e436ac94658edd2d3df7e5e.