Fallback to configured environment when no server/env environment is found

FriendsOfBehat / SymfonyExtension

:musical_score: Extension integrating Behat with Symfony.

MIT License

472 stars 62 forks source link

Fallback to configured environment when no server/env environment is found #123

Closed ubermuda closed 3 years ago

ubermuda commented 4 years ago

The test environment in our setup at work is not called test but local_test, and we had a problem where the right dotenv file was not loaded from our bootstrap (.env was loaded instead of .env.local_test).

After a quick investigation, it appears that SymfonyExtension does not use the configured environment but rather fallbacks to hardcoded test. This PR fixes that.

I have also renamed the fallbackToTestEnvironment method to better reflect its purpose.

ghost commented 3 years ago

What is the hold up here? This was approved months ago. We need this fix as well.

pamil commented 3 years ago

Thank you, Geoffrey! 🎉

ubermuda commented 3 years ago

🎉