search

FriendsOfBehat / SymfonyExtension

:musical_score: Extension integrating Behat with Symfony.
MIT License
472 stars 62 forks source link

Add PHP 8.1 compatibility #175

Closed ruudk closed 2 years ago

ruudk commented 2 years ago

Solves these errors on PHP 8.1:

Return type of FriendsOfBehat\SymfonyExtension\Mink\MinkParameters::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
ruudk commented 2 years ago

@pamil Can this be merged so that people can continue preparing their applications for PHP 8.1 that is expected to be released next week? 🙏 Best to merge together with https://github.com/FriendsOfBehat/SymfonyExtension/pull/174.

ruudk commented 2 years ago

@dunglas Are you able to approve the workflow so that we can see if the tests pass?

dunglas commented 2 years ago

@ruudk unfortunately no. I'm not a maintainer of this package.

pamil commented 2 years ago

Thanks, Ruud! 🎉

ruudk commented 2 years ago

Thanks, could you tag it?